gsmiller commented on pull request #606:
URL: https://github.com/apache/lucene/pull/606#issuecomment-1013386501
Benchmarking this change locally shows no impact at all. So I don't think
it's actually worth pushing this change unless we just want to isolate where
the nightly benchmark runs are different (i.e., see if this change regresses in
the nightly run). So if I were to merge this, it would just be to see the
nightly benchmark results and then likely revert it back out since it just adds
complexity with no apparent value. So I won't merge it righ tnow.
```
TaskQPS baseline StdDevQPS candidate
StdDev Pct diff p-value
BrowseMonthSSDVFacets 15.90 (23.7%) 15.46
(24.2%) -2.7% ( -40% - 59%) 0.717
BrowseMonthTaxoFacets 27.47 (26.8%) 27.05
(26.5%) -1.5% ( -43% - 70%) 0.858
BrowseRandomLabelSSDVFacets 9.58 (7.0%) 9.44
(4.8%) -1.4% ( -12% - 11%) 0.455
OrHighNotLow 1265.12 (3.1%) 1251.37
(2.6%) -1.1% ( -6% - 4%) 0.234
OrNotHighHigh 765.18 (3.2%) 757.45
(3.1%) -1.0% ( -7% - 5%) 0.311
OrNotHighMed 1020.03 (3.0%) 1010.06
(3.3%) -1.0% ( -7% - 5%) 0.327
IntNRQ 221.28 (1.3%) 219.28
(1.2%) -0.9% ( -3% - 1%) 0.019
OrHighNotHigh 888.59 (3.8%) 880.64
(3.7%) -0.9% ( -8% - 6%) 0.452
OrNotHighLow 828.68 (2.5%) 821.68
(1.7%) -0.8% ( -4% - 3%) 0.216
MedTermDayTaxoFacets 31.65 (4.2%) 31.41
(4.2%) -0.7% ( -8% - 7%) 0.574
HighSloppyPhrase 3.04 (4.7%) 3.02
(4.6%) -0.7% ( -9% - 9%) 0.656
OrHighNotMed 1008.99 (3.8%) 1002.52
(3.8%) -0.6% ( -8% - 7%) 0.597
BrowseRandomLabelTaxoFacets 17.52 (19.6%) 17.41
(18.9%) -0.6% ( -32% - 47%) 0.916
OrHighHigh 17.58 (3.7%) 17.47
(3.8%) -0.6% ( -7% - 7%) 0.600
OrHighMed 137.10 (3.8%) 136.28
(4.6%) -0.6% ( -8% - 8%) 0.655
LowSloppyPhrase 11.93 (3.8%) 11.88
(3.8%) -0.4% ( -7% - 7%) 0.750
LowTerm 1631.30 (2.6%) 1625.23
(2.3%) -0.4% ( -5% - 4%) 0.630
MedSloppyPhrase 67.24 (2.5%) 66.99
(2.6%) -0.4% ( -5% - 4%) 0.649
Fuzzy1 80.85 (1.6%) 80.68
(1.8%) -0.2% ( -3% - 3%) 0.699
Respell 51.74 (1.5%) 51.65
(1.7%) -0.2% ( -3% - 3%) 0.729
OrHighLow 861.47 (2.9%) 860.91
(3.0%) -0.1% ( -5% - 6%) 0.944
AndHighMedDayTaxoFacets 110.66 (1.4%) 110.63
(1.7%) -0.0% ( -3% - 3%) 0.958
MedSpanNear 50.07 (3.7%) 50.08
(3.0%) 0.0% ( -6% - 6%) 0.996
HighTermTitleBDVSort 67.00 (23.3%) 67.01
(17.4%) 0.0% ( -32% - 53%) 0.998
HighSpanNear 10.62 (3.7%) 10.62
(2.9%) 0.0% ( -6% - 6%) 0.985
Fuzzy2 71.03 (1.5%) 71.06
(1.7%) 0.0% ( -3% - 3%) 0.953
BrowseDateTaxoFacets 20.83 (22.2%) 20.84
(22.8%) 0.1% ( -36% - 57%) 0.992
LowPhrase 604.18 (2.9%) 604.76
(2.7%) 0.1% ( -5% - 5%) 0.914
BrowseDayOfYearTaxoFacets 20.82 (22.4%) 20.85
(23.0%) 0.1% ( -36% - 58%) 0.984
MedIntervalsOrdered 79.55 (5.1%) 79.68
(4.5%) 0.2% ( -8% - 10%) 0.915
HighPhrase 163.13 (2.8%) 163.42
(2.6%) 0.2% ( -5% - 5%) 0.837
OrHighMedDayTaxoFacets 7.74 (5.3%) 7.76
(4.4%) 0.2% ( -8% - 10%) 0.888
BrowseDayOfYearSSDVFacets 12.12 (14.1%) 12.17
(13.8%) 0.4% ( -24% - 32%) 0.930
LowIntervalsOrdered 187.35 (8.7%) 188.22
(7.6%) 0.5% ( -14% - 18%) 0.857
MedTerm 2446.71 (4.1%) 2458.80
(4.8%) 0.5% ( -8% - 9%) 0.728
AndHighLow 1427.63 (2.7%) 1435.06
(2.5%) 0.5% ( -4% - 5%) 0.527
AndHighHighDayTaxoFacets 9.02 (1.7%) 9.06
(2.4%) 0.5% ( -3% - 4%) 0.415
MedPhrase 34.65 (2.8%) 34.84
(2.6%) 0.6% ( -4% - 6%) 0.509
LowSpanNear 33.70 (5.5%) 33.91
(4.9%) 0.6% ( -9% - 11%) 0.705
HighIntervalsOrdered 10.85 (8.8%) 10.92
(7.9%) 0.7% ( -14% - 19%) 0.803
HighTerm 1543.65 (4.2%) 1556.45
(4.4%) 0.8% ( -7% - 9%) 0.543
AndHighMed 83.36 (4.0%) 84.36
(4.2%) 1.2% ( -6% - 9%) 0.356
PKLookup 169.56 (3.5%) 171.59
(3.4%) 1.2% ( -5% - 8%) 0.275
AndHighHigh 71.11 (4.2%) 72.08
(4.5%) 1.4% ( -7% - 10%) 0.324
HighTermMonthSort 96.47 (12.4%) 98.07
(18.7%) 1.7% ( -26% - 37%) 0.741
Wildcard 112.10 (4.5%) 114.33
(4.8%) 2.0% ( -7% - 11%) 0.180
TermDTSort 98.09 (12.0%) 100.68
(18.9%) 2.6% ( -25% - 38%) 0.598
Prefix3 206.94 (12.2%) 213.82
(10.4%) 3.3% ( -17% - 29%) 0.351
HighTermDayOfYearSort 83.83 (17.8%) 86.78
(24.5%) 3.5% ( -32% - 55%) 0.603
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
