gsmiller commented on a change in pull request #606:
URL: https://github.com/apache/lucene/pull/606#discussion_r785150523
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##########
@@ -126,23 +126,39 @@ private void countAll(IndexReader reader) throws
IOException {
NumericDocValues singleValued = DocValues.unwrapSingleton(multiValued);
if (singleValued != null) {
- for (int doc = singleValued.nextDoc();
- doc != DocIdSetIterator.NO_MORE_DOCS;
- doc = singleValued.nextDoc()) {
- if (liveDocs != null && liveDocs.get(doc) == false) {
- continue;
+ if (liveDocs != null) {
+ for (int doc = singleValued.nextDoc();
+ doc != DocIdSetIterator.NO_MORE_DOCS;
+ doc = singleValued.nextDoc()) {
+ if (liveDocs.get(doc)) {
+ values[(int) singleValued.longValue()]++;
+ }
+ }
+ } else {
Review comment:
Hmm, breaking out separate methods sent qps tanking in my local
benchmarks. Any thoughts @rmuir? Maybe I missed the mark on what you were
suggesting (entirely possible)? Here's the change:
https://github.com/apache/lucene/pull/606/commits/d084f857f568d650e64d5c40dd9b411d3ce11e85
```
TaskQPS baseline StdDevQPS candidate
StdDev Pct diff p-value
BrowseMonthTaxoFacets 27.87 (23.7%) 11.73
(1.3%) -57.9% ( -67% - -43%) 0.000
BrowseDateTaxoFacets 21.90 (20.9%) 11.77
(7.9%) -46.2% ( -62% - -21%) 0.000
BrowseDayOfYearTaxoFacets 21.88 (21.1%) 11.83
(8.1%) -45.9% ( -62% - -21%) 0.000
BrowseRandomLabelTaxoFacets 18.22 (17.8%) 9.96
(6.8%) -45.3% ( -59% - -25%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
