gsmiller commented on a change in pull request #606:
URL: https://github.com/apache/lucene/pull/606#discussion_r785195850
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##########
@@ -126,23 +126,39 @@ private void countAll(IndexReader reader) throws
IOException {
NumericDocValues singleValued = DocValues.unwrapSingleton(multiValued);
if (singleValued != null) {
- for (int doc = singleValued.nextDoc();
- doc != DocIdSetIterator.NO_MORE_DOCS;
- doc = singleValued.nextDoc()) {
- if (liveDocs != null && liveDocs.get(doc) == false) {
- continue;
+ if (liveDocs != null) {
+ for (int doc = singleValued.nextDoc();
+ doc != DocIdSetIterator.NO_MORE_DOCS;
+ doc = singleValued.nextDoc()) {
+ if (liveDocs.get(doc)) {
+ values[(int) singleValued.longValue()]++;
+ }
+ }
+ } else {
Review comment:
Thanks @rmuir. Just to make sure we're on the same page, the main
difference is just moving to `static` methods right? I've made that change and
still seeing serious regressions. Anything else I might be missing here? Thanks
again for your thoughts!
```
TaskQPS baseline StdDevQPS candidate
StdDev Pct diff p-value
BrowseMonthTaxoFacets 29.96 (14.4%) 12.03
(1.6%) -59.8% ( -66% - -51%) 0.000
BrowseDateTaxoFacets 22.78 (13.5%) 12.33
(5.5%) -45.9% ( -57% - -31%) 0.000
BrowseDayOfYearTaxoFacets 22.77 (13.8%) 12.41
(5.6%) -45.5% ( -57% - -30%) 0.000
BrowseRandomLabelTaxoFacets 19.00 (10.7%) 10.41
(5.1%) -45.2% ( -55% - -32%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
