gf2121 commented on pull request #602:
URL: https://github.com/apache/lucene/pull/602#issuecomment-1013925047


   Thanks.
   
   > Did you check for other ReadVint variants? There may be more. Maybe use 
the type hierarchy functions to investigate all child classes of DataInput.
   
   I'm using IntelliJ IDEA and it can help detect child classes that override 
the readVInt/readVLong. I also greped `long readVLong` to avoid similar fork 
(but not override) like what we do in  `BlockPackedReaderIterator`. It seems 
there is no other ReadVint variants.
   
   **readVInt**
   
   
   
![image](https://user-images.githubusercontent.com/52390227/149672000-8191959a-aa41-4c6f-83ae-1938d3ad7711.png)
   
   
   
![image](https://user-images.githubusercontent.com/52390227/149672276-7deda6b3-ba6e-4489-af5f-3a413617cc51.png)
   
   
   **readVLong**
   
   
   
![image](https://user-images.githubusercontent.com/52390227/149672009-db63a639-c1b7-4c84-ae26-cf82c1d10d12.png)
   
   
   
![image](https://user-images.githubusercontent.com/52390227/149672293-158081ac-80d5-4329-8498-5ed1b7e61eba.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to