Greg Miller created LUCENE-10381:
------------------------------------
Summary: Require users to provide FacetsConfig with initializing
DefaultSortedSetDocValuesReaderState
Key: LUCENE-10381
URL: https://issues.apache.org/jira/browse/LUCENE-10381
Project: Lucene - Core
Issue Type: Improvement
Components: modules/facet
Reporter: Greg Miller
In LUCENE-10250, we added the ability for users to provide their
{{FacetsConfig}} when constructing
{{{}DefaultSortedSetDocValuesReaderState{}}}. This is necessary for some of the
new functionality and bug fixes in SSDV faceting (e.g., we need to know if a
dim is configured as hierarchical, multivalued and/or requiring dim counts). To
remain backwards-compatible, existing ctors were maintained and users don't
need to provide config, which means we have to fall back to some default
(pre-existing) behavior if we don't have the config.
We should make the config mandatory going forward so that users always
explicitly provide their config. This is consistent with taxonomy faceting
where users must provide config. It's also pretty trappy to let users setup
their state without config as they might just overlook the need to provide it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
