msokolov commented on a change in pull request #623:
URL: https://github.com/apache/lucene/pull/623#discussion_r791947019
##########
File path: lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java
##########
@@ -201,7 +201,7 @@ public void testSearchWithSkewedAcceptOrds() throws
IOException {
CircularVectorValues vectors = new CircularVectorValues(nDoc);
HnswGraphBuilder builder =
new HnswGraphBuilder(
- vectors, VectorSimilarityFunction.DOT_PRODUCT, 16, 100,
random().nextInt());
+ vectors, VectorSimilarityFunction.EUCLIDEAN, 16, 100,
random().nextInt());
Review comment:
or ... is the idea that you wanted to change the test so that it would
verify the correctness of the ordering, because we didn't have any tests using
EUCLIDEAN (ie inverted) scores before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]