cpoerschke commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r792916357
##########
File path:
solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFeature.java
##########
@@ -33,6 +33,9 @@ public void testFilterFeatureScorerOverridesScorerMethods() {
// the FilterFeatureScorer may simply inherit Scorer's default
implementation
if (scorerClassMethod.getName().equals("twoPhaseIterator")) continue;
+ // the FilterFeatureScorer may simply inherit Scorer's default
implementation
+ if (scorerClassMethod.getName().equals("smoothingScore")) continue;
+
Review comment:
This surprised me. Created
https://issues.apache.org/jira/browse/SOLR-15958 and (draft)
https://github.com/apache/solr/pull/567 to consider further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
