javanna commented on a change in pull request #622: URL: https://github.com/apache/lucene/pull/622#discussion_r794326102
########## File path: lucene/misc/src/test/org/apache/lucene/misc/search/TestDocValuesStatsCollector.java ########## @@ -396,10 +394,8 @@ public void testDocsWithSortedSetValues() throws IOException { try (DirectoryReader reader = DirectoryReader.open(indexWriter)) { IndexSearcher searcher = new IndexSearcher(reader); SortedSetDocValuesStats stats = new SortedSetDocValuesStats(field); - TotalHitCountCollector totalHitCount = new TotalHitCountCollector(); - searcher.search( - new MatchAllDocsQuery(), - MultiCollector.wrap(totalHitCount, new DocValuesStatsCollector(stats))); + + searcher.search(new MatchAllDocsQuery(), new DocValuesStatsCollector(stats)); Review comment: I can also revert this bit for now if we are not sure, this change is not strictly needed and I will encounter it again soon when trying to get rid of usages of the search method that takes a collector as argument -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org