uschindler commented on a change in pull request #643: URL: https://github.com/apache/lucene/pull/643#discussion_r800054704
########## File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java ########## @@ -528,7 +528,7 @@ public static void fsync(Path fileToSync, boolean isDir) throws IOException { } /** - * A resource supplier function that may throw on IOException + * A resource supplier function that may throw an IOException Review comment: I think we should add a note that the consumer has to close the resource (eg., use try-with-resources) and the supplier can count on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org