rmuir commented on pull request #681: URL: https://github.com/apache/lucene/pull/681#issuecomment-1041345085
Yeah, those are actually API bugs? We have public methods that have non-public classes in their signature. Looks like this will be more complex to fix up. In this example of `ByteBufferIndexInput.newInstance` and its `ByteBufferGuard` parameter, I think a better solution is to make `ByteBufferIndexInput.newInstance` package-private. The only callers are `ByteBuffersDirectory` and `MMapDirectory` which are in the same package. Then we don't need to make `ByteBufferGuard` public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
