mayya-sharipova commented on a change in pull request #649:
URL: https://github.com/apache/lucene/pull/649#discussion_r807998586
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
##########
@@ -1018,4 +1020,57 @@ public void testAdvance() throws Exception {
}
}
}
+
+ public void testVectorValuesReportCorrectDocs() throws Exception {
+ final int numDocs = atLeast(1000);
+ final int dim = random().nextInt(20) + 1;
+ final VectorSimilarityFunction similarityFunction =
+ VectorSimilarityFunction.values()[
+ random().nextInt(VectorSimilarityFunction.values().length)];
+
+ float fieldValuesCheckSum = 0f;
+ int fieldDocCount = 0;
+ long fieldSumDocIDs = 0;
+
+ try (Directory dir = newDirectory();
+ RandomIndexWriter w = new RandomIndexWriter(random(), dir,
newIndexWriterConfig())) {
+ for (int i = 0; i < numDocs; i++) {
+ Document doc = new Document();
+ int docID = random().nextInt(numDocs);
+ doc.add(new StoredField("id", docID));
+ if (random().nextInt(4) == 3) {
+ float[] vector = randomVector(dim);
+ doc.add(new KnnVectorField("knn_vector", vector,
similarityFunction));
+ fieldValuesCheckSum += vector[0];
+ fieldDocCount++;
+ fieldSumDocIDs += docID;
+ }
+ w.addDocument(doc);
+ }
+
+ if (random().nextBoolean()) {
+ w.forceMerge(1);
+ }
+
+ try (IndexReader r = w.getReader()) {
+ float checksum = 0;
Review comment:
@jtibshirani Thanks for your feedback and comment. What did you mean by
"vectors were out of order"? `VectorValues` `extends DocIdSetIterator` and
are expected to be accessed in the increasing doc ID order.
Or did you mean `RandomAccessVectorValues`? I think this class doesn't
concern itself with doc Ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
