rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1049905030
To try to be more helpful, here's what i'd propose. I can try to hack up a
draft PR later if we want, if it is helpful.
DocIdSetBuilder, remove complex cost estimation:
* remove `DocIdSetBuilder(int, Terms)` constructor
* remove `DocIdSetBuilder(int, PointValues)` constructor
* remove `DocIdSetBuilder.counter` member
* remove `DocIdSetBuilder.multiValued` member
* remove `DocIdSetBuilder.numValuesPerDoc` member
DocIdSetBuilder: add sugar `grow(long)` for style purposes:
```
/** sugar: to just make code look pretty, nothing else */
public BulkAdder grow(long numDocs) {
grow((int) Math.min(Integer.MAX_VALUE, numDocs));
}
```
FixedBitSet: implement `approximateCardinality()` and simply use it when
estimating cost() here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
