sonatype-lift[bot] commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r816701565
##########
File path: lucene/distribution/src/binary-release/bin/luke.sh
##########
@@ -17,5 +17,12 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" && pwd`
-java --module-path "$MODULES/modules:$MODULES/modules-thirdparty" --module
org.apache.lucene.luke "$@"
+
+if [ -n "$LAUNCH_CMD" ]; then
+ # launch command overridden (for tests).
+else
Review comment:
*ShellCheck:* Can't have empty then clauses (use 'true' as a no-op).
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with
`help` or `ignore`)
##########
File path: lucene/distribution/src/binary-release/bin/luke.sh
##########
@@ -17,5 +17,12 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" && pwd`
-java --module-path "$MODULES/modules:$MODULES/modules-thirdparty" --module
org.apache.lucene.luke "$@"
+
+if [ -n "$LAUNCH_CMD" ]; then
Review comment:
*ShellCheck:* Couldn't parse this then clause. Fix to allow more checks.
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with
`help` or `ignore`)
##########
File path: lucene/distribution/src/binary-release/bin/luke.sh
##########
@@ -17,5 +17,12 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" && pwd`
-java --module-path "$MODULES/modules:$MODULES/modules-thirdparty" --module
org.apache.lucene.luke "$@"
+
+if [ -n "$LAUNCH_CMD" ]; then
+ # launch command overridden (for tests).
+else
Review comment:
*ShellCheck:* Unexpected keyword/token. Fix any mentioned problems and
try again.
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with
`help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
