uschindler commented on a change in pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#discussion_r830460575
##########
File path: lucene/common-build.xml
##########
@@ -63,7 +63,7 @@
<fail message="If you pass -Dversion=... to set a release version, it must
match "${version.base}", optionally followed by a suffix (e.g.,
"-SNAPSHOT").">
<condition>
- <not><matches pattern="^\Q${version.base}\E(|\-.*)$"
casesensitive="true" string="${version}"/></not>
+ <not><matches pattern="^\Q${version.base}\E(|.*)$" casesensitive="true"
string="${version}"/></not>
</condition>
Review comment:
At least there must be a `\b` (boundary) instead of the dash. The
current change would match a version like 1.2.34 as valid for 1.2.3 base
version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
