reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083295848
> To me it'd be best to only tackle the main bug you ran into, the ClassCastException when using integers. To prevent errors when using double and float values, we could add an explicit check and disable the optimization in this case, and clarify in the javadoc that only LONG and INT are supported. @jtibshirani I was phasing out FLOAT / DOUBLE support, as per your comment, but the implementation we will end up with becomes very inconsistent and confusing, for example `SortedNumericSortField` happily deals with FLOAT / DOUBLE (see please its `SortFieldProvider` implementation https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/SortedNumericSortField.java#L109). It looks to me we either remove it from all places or consistently support it in all places, what do you think? @nknize @jpountz may be you guys could also advice? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
