nknize commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r840219946
##########
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java
##########
@@ -155,15 +156,23 @@ public void testToString() {
}
public void testIndexSortDocValuesWithEvenLength() throws Exception {
- testIndexSortDocValuesWithEvenLength(false);
- testIndexSortDocValuesWithEvenLength(true);
+ final SortField.Type type =
+ RandomPicks.randomFrom(
+ random(),
+ new SortField.Type[] {
+ SortField.Type.INT, SortField.Type.LONG, SortField.Type.DOUBLE,
SortField.Type.FLOAT
Review comment:
RandomPicks was suggested to avoid the original java annotation
approach. I like @jtibshirani idea of explicitly testing through the foreach...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
