jpountz commented on code in PR #767:
URL: https://github.com/apache/lucene/pull/767#discussion_r842414103


##########
lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java:
##########
@@ -65,20 +65,21 @@ public void testDocValuesRewriteWithTermsPresent() throws 
IOException {
     dir.close();
   }
 
-  public void testDocValuesRewriteWithPointValuesPresent() throws IOException {
+  public void testDocValuesRewriteWithDocValuesPresent() throws IOException {
     Directory dir = newDirectory();
     RandomIndexWriter iw = new RandomIndexWriter(random(), dir);
     final int numDocs = atLeast(100);
     for (int i = 0; i < numDocs; ++i) {
       Document doc = new Document();
-      doc.add(new BinaryPoint("dim", new byte[4], new byte[4]));
+      doc.add(new DoubleDocValuesField("f", 2.0));
+      doc.add(new StringField("f", random().nextBoolean() ? "yes" : "no", 
Store.NO));

Review Comment:
   I think we should keep the name and intention of this test by indexing a 
point field rather than a StringField, in addition to the doc-values field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to