[
https://issues.apache.org/jira/browse/LUCENE-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10505:
-----------------------------------
Description:
In oal.util.Constants we have some constants about the 64 bitness and Java
version and vendor info. Especially theres also parsing of system properties to
get major and minor Java version.
We should change this in main and 9.x to use
[https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.html#version()]
and the corresponding {{Runtime.Version}} class. The {{Runtime.Version}} class
also allows to compare in a safe way. The good thing is that you also get minor
bugfix info, so code could disable stuff exactly at specific versions that are
buggy.
We should also cleanup the constants. In 9.x and main we still have
{{JRE_IS_MINIMUM_JAVA8}}! We should remove this constants (+ deprecate in 9.x
and set to true) and change all code relying on the to execute code for java 8.
Same for 11 and 17.
was:
In oal.util.Constants we have some constants about the 64 bitness and Java
version and vendor info. Especially theres also parsing of system properties to
get major and minor Java version.
We should change this in main and 9.x to use
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.html#version()
and the version class. The version class also allows to compare in a safe way.
The good thing is that you also get minor bugfix info, so code could disable
stuff exactly at specific versions that are buggy.
We should also cleanup the constants. In 9.x and main we still have
`JRE_IS_MINIMUM_JAVA8`! We should remove this constants (+ deprecate in 9.x and
set to true) and change all code relying on the to execute code for java 8.
Same for 11 and 17.
> Cleanup oal.util.Constants to use java.lang.Runtime.Version and remove
> outdated versions
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-10505
> URL: https://issues.apache.org/jira/browse/LUCENE-10505
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 9.0, 9.1, 10.0 (main)
> Reporter: Uwe Schindler
> Priority: Major
> Labels: cleanup
>
> In oal.util.Constants we have some constants about the 64 bitness and Java
> version and vendor info. Especially theres also parsing of system properties
> to get major and minor Java version.
> We should change this in main and 9.x to use
> [https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.html#version()]
> and the corresponding {{Runtime.Version}} class. The {{Runtime.Version}}
> class also allows to compare in a safe way. The good thing is that you also
> get minor bugfix info, so code could disable stuff exactly at specific
> versions that are buggy.
> We should also cleanup the constants. In 9.x and main we still have
> {{JRE_IS_MINIMUM_JAVA8}}! We should remove this constants (+ deprecate in 9.x
> and set to true) and change all code relying on the to execute code for java
> 8. Same for 11 and 17.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
