rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1103272545
> I agree with this (as someone who disables the daemon and runs the commands every time). The only reason I specified it as a different command was due to the fact that if the downloader fails, the error is "trapped" and an additional version-related error (that you need at least java 11) is printed... IMO that's a bit confusing, but I get it. we can clean up exit status so that wrapperdownloader uses something other than `1` when it fails. that's also the same status old `java` uses when it doesn't recognize `--source` parameter. then we can move the version check into wrapperdownloader and only say "please make sure you're using at least java 11" when it is relevant (java itself fails). and it is safe to only apply it to exit status `1` because it is only relevant to already-released older jvms. I will look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
