rmuir commented on PR #836:
URL: https://github.com/apache/lucene/pull/836#issuecomment-1108916100

   OK i looked into some surrounding behavior in suggest module:
   
   Looks like returning empty list is what DirectSpellChecker does:
   
   
https://github.com/apache/lucene/blob/main/lucene/suggest/src/java/org/apache/lucene/search/spell/DirectSpellChecker.java#L317-L320
   
   And it seems to be behavior of suggesters too?
   
   
https://github.com/apache/lucene/blob/main/lucene/suggest/src/test/org/apache/lucene/search/suggest/fst/TestFSTCompletion.java#L208-L211
   
   So given the choice, I think let's go with consistency and return empty 
list. sorry for the noise...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to