vigyasharma commented on PR #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1111110200
> I think it would be worth implementing the new MergePolicy method in either MockRandomMergePolicy or AlcoholicMergePolicy or maybe both to exercise concurrent addIndexes across any tests today or future tests that use addIndexes? Great idea @mikemccand, thanks for the input, and for reviewing this PR. I added the new merge policy to `MockRandomMergePolicy`, configured to trigger with 50% probability, and found some new failures in existing tests. I'm working on fixing them on my box, will update this PR soon (along with your other suggestions). For `AlcoholicMergePolicy`, I think it is mostly about randomizing the size of participating segments, while the findMerges(CodecReader[]) that I'm currently proposing, doesn't really take sizes into account. I'll leave it as is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
