[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10538:
--------------------------------
Description: When looking at the overridden implementation
getTopChildren(int topN, String dim, String... path) in RangeFacetCounts, I
found that the topN parameter is not being used in the code, and the unit tests
did not test this function properly. I will create a PR to fix this, and will
look into other overridden implementations and see if they have the same issue.
Please let me know if there is any question. Thanks! (was: When looking at the
overridden implementation getTopChildren(int topN, String dim, String... path)
in RangeFacetCounts, I found that the topN parameter is not being used in the
code, and the unit tests did not test this function properly. I created PR
[https://github.com/apache/lucene/pull/843] to fix this, and will look into
other overridden implementations and see if they have the same issue. Please
let me know if there is any question. Thanks!)
> TopN is not being used in getTopChildren()
> ------------------------------------------
>
> Key: LUCENE-10538
> URL: https://issues.apache.org/jira/browse/LUCENE-10538
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Yuting Gan
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When looking at the overridden implementation getTopChildren(int topN, String
> dim, String... path) in RangeFacetCounts, I found that the topN parameter is
> not being used in the code, and the unit tests did not test this function
> properly. I will create a PR to fix this, and will look into other overridden
> implementations and see if they have the same issue. Please let me know if
> there is any question. Thanks!
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
