gsmiller commented on PR #843: URL: https://github.com/apache/lucene/pull/843#issuecomment-1112797399
> Are you suggesting that I add another getAllChildren API to retain the current behavior of getTopChildren, and then fix getTopChildren by returning ranges sorted by counts, or do you mean we should just keep this API untouched? Thanks! I'm suggesting the former, but I think that's a bigger project that you meant to capture with this PR and associated Jira. I would recommend opening a separate Jira issue to propose the idea of adding `getAllChildren` to `Facets`. We have use-cases for that functionality here (but it's just sort of improperly implemented under `getTopChildren`) and also in `LongValueFacetCounts` (see `#getAllChildrenSortByValue`). I think it's reasonable to add that functionality to all faceting implementations and then come up with a migration plan to move the current `RangeFacetCounts#getTopChildren` over and properly implement `RangeFacetCounts#getTopChildren`. But by opening a Jira, maybe others will weigh in and agree/disagree there, which would be a healthy conversation. Thanks again for digging into this and working on improving faceting! This is great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
