[GitHub] [lucene] jpountz commented on a diff in pull request #780: LUCENE-10496: avoid unnecessary attempts to evaluate skipping doc if index sort and search sort are in opposite direction

[GitBox]

jpountz commented on code in PR #780:
URL: https://github.com/apache/lucene/pull/780#discussion_r868900109


##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -42,6 +42,8 @@
  * but in this case you must override both of these methods.
  */
 public abstract class NumericComparator<T extends Number> extends 
FieldComparator<T> {
+  private final int minSkipInterval = 32;
+  private final int maxSkipInterval = 8192;

Review Comment:
   Can you make these constants (`private static final int MIN_SKIP_INTERVAL = 
32`) and leave a comment that they need to be powers of 2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org