[
https://issues.apache.org/jira/browse/LUCENE-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535872#comment-17535872
]
Tomoko Uchida commented on LUCENE-10561:
----------------------------------------
{quote}One followup question. Should I change only the classes that are
Normalizer or Stemmer in this PR and not touch other classes ?
{quote}
I'd agree with that. It'd be better not to touch Tokenizer/TokenFilters in this
issue. It's another issue and changing them will break users' code; we'd need
to be careful about it.
> Reduce class/member visibility of ArabicStemmer, ArabicNormalizer, and
> PersianNormalizer
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-10561
> URL: https://issues.apache.org/jira/browse/LUCENE-10561
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Tomoko Uchida
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is a spin-off of [LUCENE-10312].
> Constants and methods in those classes are exposed to the outside packages;
> we should be able to limit the visibility to {{private}} or, at least to
> {{package private}}.
> This change breaks backward compatibility so should be applied to the main
> branch (10.0) only, and a MIGRATE entry may be needed.
> Also, they seem unchanged since 2008, we could refactor them to embrace newer
> Java APIs as we did in [https://github.com/apache/lucene/pull/540].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
