rmuir commented on code in PR #913:
URL: https://github.com/apache/lucene/pull/913#discussion_r878550812
##########
lucene/core/src/java/org/apache/lucene/util/VectorUtil.java:
##########
@@ -213,4 +213,21 @@ public static void add(float[] u, float[] v) {
u[i] += v[i];
}
}
+
+ public static float dotProduct(BytesRef a, int aOffset, BytesRef b, int
bOffset, int len) {
+ // fixme -- move to codec? What if later we want to access the bytes some
other way?
+ int total = 0;
+ for (int i = 0; i < len; i++) {
+ total += a.bytes[aOffset++] * b.bytes[bOffset++];
Review Comment:
Is this really the way the function should work?
it is doing the equivalent of casting both `a` and `b` to `int` first, and
then adding result to another `int`. That's just how java promotion works.
But is this what we want? What about overflow? why `int` and not `long`?
This is not at all what `ByteVector.mul()` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
