[GitHub] [lucene] Yuti-G commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

[GitBox]

Yuti-G commented on PR #915:
URL: https://github.com/apache/lucene/pull/915#issuecomment-1138850060

   > But: the `getAllDims` time for SSDV seems to have gotten much faster with 
this PR, which is great! Was that expected? Or is this some horrible noise? Is 
it repeatable?
   
   I think it's just noise. I just re-run the dedicated luceneutil faceting 
benchmark against the main branch:
   
   1st run:
   <img width="839" alt="Screen Shot 2022-05-26 at 9 55 35 AM" 
src="https://user-images.githubusercontent.com/44444710/170536870-929c6d0d-1d47-4fb3-bd80-c30e62c8d51e.png";>
   
   2nd run:
   <img width="824" alt="Screen Shot 2022-05-26 at 9 56 07 AM" 
src="https://user-images.githubusercontent.com/44444710/170536986-492cf393-c3f7-4248-bdb7-60ceec0aa1e7.png";>
   
   3rd run:
   <img width="889" alt="Screen Shot 2022-05-26 at 10 49 52 AM" 
src="https://user-images.githubusercontent.com/44444710/170546269-34be4600-e384-4e18-bd0f-cc7ac3936a6e.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org