mocobeta commented on PR #927: URL: https://github.com/apache/lucene/pull/927#issuecomment-1145541063
> I would like to understand the performance impact of this wrapping. If you have time, it would be great to get some results from https://github.com/mikemccand/luceneutil benchmarking utility that was recently enhanced to support ExitableDirectoryReader - and I think we could add a call to this new method; see https://github.com/mikemccand/luceneutil/issues/168 I don't think the `exitable` parameter (that is recently added in luceneutil to measure the performance overhead of the periodic check for `ExitableDirectoryReader`) is applicable to this - this does not use `ExitableDirectoryReader` but checks if it exceeds the time budget by the new BulkScorer. I'd agree with it's great if we can measure its impact on performance though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
