mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1152603748
>Is this about providing enough information to optimize with KD/R-Trees? If that's the case, I don't think we want a matches(long[]) method right? We just need a way for the FSM instances to expose their bounding-boxes. I don't think we even need to store the original long[] array to do this. I just wanted to point out here that the reason I wanted a `long[]` API was to support KD/R-Trees, but if we don't need it to add support, then I think there is no reason for `long[]`. I feel like having 2 `matches` functions in this case would make the API unnecessarily complex. If the user is extending the FSM, then I feel like they could figure out the `byte[]` API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
