shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1159759023
@gsmiller, @mdmarshmallow I pushed another commit which completes the FacetSets document and adds another check ensuring all `FacetSet` given to the `FacetSetField` are actually of the same type (no sense indexing different types under the same field). The PR feels ready to me, except `RangeMatching` which I'm waiting for @mdmarshmallow to comment about whether he agrees to remove it or not. After we agree on that, I suggest that we do a final round of review and wrap up this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
