LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r903314253
##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -439,29 +433,42 @@ private void set() {
static final class DocOrds {
final long[] offsets;
final PackedLongValues ords;
+ final GrowableWriter growableWriter;
+
+ public static final int START_BITS_PER_VALUE = 2;
Review Comment:
`BitsPerValue` was required for `GrowableWriter`, we could count
`maxBitsRequired` while adding values in `SortedSetDocValuesWriter`, but
`SortingSortedSetDocValues` was also used in
`SortingCodecReader#getDocValuesReader#getSortedSet` which could not supply a
`BitsPerValue`, so we have to a default value, could you give some suggestion
base on practice for `START_BITS_PER_VALUE ` , @jpountz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
