jpountz commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r907109652
##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -382,23 +386,20 @@ public int advance(int target) {
public boolean advanceExact(int target) throws IOException {
// needed in IndexSorter#StringSorter
docID = target;
+ initCount();
ordUpto = ords.offsets[docID] - 1;
return ords.offsets[docID] > 0;
}
@Override
public long nextOrd() {
- long ord = ords.ords.get(ordUpto++);
- if (ord == 0) {
- return NO_MORE_ORDS;
- } else {
- return ord - 1;
- }
+ return ords.ords.get(ordUpto++);
Review Comment:
We should keep returning NO_MORE_ORDS when ords are exhausted.
##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -415,34 +416,43 @@ public BytesRef lookupOrd(long ord) throws IOException {
public long getValueCount() {
return in.getValueCount();
}
+
+ private void initCount() {
+ assert docID >= 0;
+ count = (int) ords.growableWriter.get(docID);
+ }
}
static final class DocOrds {
final long[] offsets;
final PackedLongValues ords;
+ final GrowableWriter growableWriter;
Review Comment:
Let's call it `docValueCounts` or something like that that better reflects
what it stores?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
