luyuncheng commented on PR #1047: URL: https://github.com/apache/lucene/pull/1047#issuecomment-1196542776
> Since you are optimizing this call, can you remove the `DataInput` and `numBytes` parameters from the `BytesStore` constructor, and fix call sites to call `BytesStore#copyBytes` instead? LGTM, i removed `DataInput` and `numBytes` parameters from the `BytesStore` constructor in commits [4b9f4b](https://github.com/apache/lucene/pull/1047/commits/4b9f4b35479246aa17fdd6e2628d4f3460cb98a4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
