mocobeta commented on code in PR #108:
URL:
https://github.com/apache/lucene-jira-archive/pull/108#discussion_r936795884
##########
migration/src/jira_util.py:
##########
@@ -287,9 +276,23 @@ def escape_gh_issue_link(m: re.Match):
disp_name = jira_users.get(jira_id)
gh_m = account_map.get(jira_id)
# replace Jira name with GitHub account or Jira display name if it
is available, othewise show Jira name with ``
- mention = lambda: f"@{gh_m}" if gh_m else disp_name if disp_name
else f"`~{jira_id}`"
+ mention = lambda: f"@{gh_m}" if gh_m else disp_name if disp_name
else f"`@{jira_id}`"
text = text.replace(m, mention())
+ # escape tilde to avoid unintentional strike-throughs in Markdown
+ text = text.replace("~", "\~")
Review Comment:
Escape `~` **before** Markdown conversion and **after** mention conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
