iverase opened a new pull request, #1065: URL: https://github.com/apache/lucene/pull/1065
We currently compute the partition point for a set of points by multiplying the number of nodes that needs to be on the left of the BKD tree by the maxPointsInLeafNode. This multiplication is done on the integer space so if the partition point is bigger than Integer.MAX_VALUE it will overflow. This may happen for high dimension cases (numDims > 1) and when documents are multivalued. This PR moves the multiplication to the long space so it doesn't overflow. In order to test it I modify the test `Test2BBKDPoints` to index 4Billion points instead and test is renamed accordingly. That should be fine, this test was developed before we improve the efficiency of the tree so CI should be ok running it in Monster runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
