rmuir commented on code in PR #11738:
URL: https://github.com/apache/lucene/pull/11738#discussion_r966326978
##########
lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java:
##########
@@ -179,8 +189,29 @@ private WeightOrDocIdSet rewrite(LeafReaderContext
context) throws IOException {
return new WeightOrDocIdSet(weight);
}
- // Too many terms: go back to the terms we already collected and start
building the bit set
+ // Too many terms: we'll evaluate the term disjunction and populate a
bitset. We start with
+ // the terms we haven't seen yet in case one of them matches all docs
and lets us optimize
+ // (likely rare in practice):
Review Comment:
i'd prefer we didn't do this "backwards" because it means we no longer
traverse everything sequentially like we previously did?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
