jpountz commented on code in PR #11793:
URL: https://github.com/apache/lucene/pull/11793#discussion_r975300662
##########
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##########
@@ -104,28 +104,28 @@ public abstract class NumericLeafComparator implements
LeafFieldComparator {
public NumericLeafComparator(LeafReaderContext context) throws IOException
{
this.docValues = getNumericDocValues(context, field);
- this.pointValues = canSkipDocuments ?
context.reader().getPointValues(field) : null;
- if (pointValues != null) {
- FieldInfo info = context.reader().getFieldInfos().fieldInfo(field);
- if (info == null || info.getPointDimensionCount() == 0) {
- throw new IllegalStateException(
- "Field "
- + field
- + " doesn't index points according to FieldInfos yet returns
non-null PointValues");
- } else if (info.getPointDimensionCount() > 1) {
- throw new IllegalArgumentException(
- "Field " + field + " is indexed with multiple dimensions,
sorting is not supported");
- } else if (info.getPointNumBytes() != bytesCount) {
- throw new IllegalArgumentException(
- "Field "
- + field
- + " is indexed with "
- + info.getPointNumBytes()
- + " bytes per dimension, but "
- + NumericComparator.this
- + " expected "
- + bytesCount);
- }
+ FieldInfo info = context.reader().getFieldInfos().fieldInfo(field);
+ if (info == null || info.getPointDimensionCount() == 0) {
+ throw new IllegalStateException(
Review Comment:
This doesn't look correct to me as it would throw an exception if the field
doesn't exist, which should be supported. Previously it would only fail if the
field would not exist AND the reader provides point values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
