rmuir commented on PR #11985: URL: https://github.com/apache/lucene/pull/11985#issuecomment-1330867303
I don't really think it is especially trappy, since the default implementation is `O(log N)` and works consistently with FilterTerms classes by default even if they are actually filtering the terms data in some way. But seems fine to look at making it abstract (as separate change), as long as there is an easy way to opt-in to the existing binary search impl. Would not be good to see that duplicated across a bunch of simple Terms subclasses (e.g. in indexer, in term vectors, docvalues, whatever). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
