jpountz commented on PR #12079: URL: https://github.com/apache/lucene/pull/12079#issuecomment-1380286154
I remember thinking about it, and there are legitimate use-cases for `Arrays#compareUnsigned` like `BytesRef#compareTo`. Another thing is that `ArrayUtil#getUnsignedComparator` only helps if we expect the lengths to compare to be commonly 4 or 8, otherwise it just wraps `Arrays#compareUnsigned`. But to your point, maybe we could do another round or review of all call sites or `Arrays#compareUnsigned` to see if there are some of them that should switch to `ArrayUtil#getUnsignedComparator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org