javanna commented on code in PR #12102:
URL: https://github.com/apache/lucene/pull/12102#discussion_r1084564868
##########
lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java:
##########
@@ -284,7 +285,9 @@ private static class SortingByteVectorValues extends
ByteVectorValues {
for (int doc = delegate.nextDoc(); doc != NO_MORE_DOCS; doc =
delegate.nextDoc()) {
int newDocID = sortMap.oldToNew(doc);
docsWithField.set(newDocID);
- binaryVectors[newDocID] = BytesRef.deepCopyOf(delegate.vectorValue());
+ binaryVectors[newDocID] =
Review Comment:
yep I remember being lazy there and then wanting to go back but could not
find it anymore. I will fix it, thanks for raising this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
