shubhamvishu commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1454792105
Thanks for the quick feedback @rmuir @uschindler ! > the change to BlendedTermQuery makes the code nearly unreadable. It is important to be able to understand how it is literally "blending the stats". Can we please find a way to make this feature less invasive? Sure, this was to get some initial feedback on whether this would make sense so haven't focussed much on those aspects. I'll try to make it more cleaner in the next revision and see how that turns out. > Personally I don't think we should do this. Maybe the API needs to be rethought. I see race conditions being added in this change, now this adds potential for all kinds of crazy bugs in lucene. I don't think any performance gain is worth that. Agreed. We should definitely not have any race conditions here. I'll try to address these and other suggestions. Maybe we could then evaluate if this would be beneficial and worth the possible benefits of concurrency or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
