cfournie commented on code in PR #12249:
URL: https://github.com/apache/lucene/pull/12249#discussion_r1179529497


##########
lucene/core/src/test/org/apache/lucene/util/graph/TestGraphTokenStreamFiniteStrings.java:
##########
@@ -660,4 +661,27 @@ public void testMultipleSidePathsWithGaps() throws 
Exception {
         it.next(), new String[] {"king", "alfred", "saxons", "ruled"}, new 
int[] {1, 1, 3, 1});
     assertFalse(it.hasNext());
   }
+
+  public void testLongTokenStreamStackOverflowError() throws Exception {
+    ArrayList<Token> tokens =
+        new ArrayList<Token>() {
+          {
+            add(token("turbo", 1, 1));
+            add(token("fast", 0, 2));
+            add(token("charged", 1, 1));
+            add(token("wi", 1, 1));
+            add(token("wifi", 0, 2));
+            add(token("fi", 1, 1));
+          }
+        };
+
+    // Add in too many tokens to get a high depth graph
+    for (int i = 0; i < 1024 * 10; i++) {

Review Comment:
   On my machine values above 8k trigger a `StackOverflowError`, but 
unfortunately this is JVM implementation and JVM setting dependent; if you set 
a higher 
[`-Xss`](https://docs.oracle.com/en/java/javase/11/tools/java.html#GUID-3B1CE181-CD30-4178-9602-230B800D4FAE)
 you could stave off this `StackOverflowError` for more tokens.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to