uschindler commented on code in PR #12268:
URL: https://github.com/apache/lucene/pull/12268#discussion_r1187617649
##########
lucene/core/src/java/org/apache/lucene/util/BitSet.java:
##########
@@ -43,6 +43,16 @@ public static BitSet of(DocIdSetIterator it, int maxDoc)
throws IOException {
return set;
}
+ /**
+ * Clear all the bits of the set.
+ *
+ * <p>Depending on the implementation, this may be significantly faster than
clear(0, length).
+ */
+ public void clear() {
+ // default implementation for compatibility with possible out-of-tree code
Review Comment:
Out of tree means code (e.g., outside Lucene) which subclasses abstract
BitSet. But as `clear()` without parameters is new it therefore does not
implement it. In interfaces this is what "default" classifier on method means.
The comment was correct but misleading. Backwards compatibility is here
about code subclassing a public class with well defined interface. Those can't
suddenly add abstract methods without a default implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
