jimczi commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1540666019
I think both 1 and 2 yes. If you think this PR will benefit the other PR then it should be discussed in https://github.com/apache/lucene/pull/12254. We already have issues with indexing so adding new requirements outside of this use case should be avoided imo. The thing I don't like with this change alone is that it makes it like if using the HNSW builder for a search use case is ok. That's not right, nobody should use the HNSW builder as a static searcher. If we make it multi-threaded it should be to make the build faster. Search is exposed in the builder simply because it is used by the algorithm to create the graph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
