dsmiley commented on PR #12306: URL: https://github.com/apache/lucene/pull/12306#issuecomment-1553633051
All limits are magic numbers :-). Maybe you mean, lets add a bit of docs in the code to reflect why it is what it is? From some of the conversation threads, I recall 2048 is the highest number I saw thrown around as might be useful. What matters here in this PR, I see from some folks, is that it's a _supportable_ number. Tests pass with it. If you recommend a different number then lets here it but I admit not being too concerned with it. The default 1024 matters much more and that's not changing here. In my latest commit, I had it log a warning if 2048 is exceeded. My thinking is that maybe somebody wants to benchmark it just to see if it works but not actually use it in a production setting. I don't love a hard (exception) upper limit but I suspect some people might consider this a veto-worthy objection. You've got to wear armor in this community to be a part of it for long :-/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
