uschindler commented on code in PR #12311:
URL: https://github.com/apache/lucene/pull/12311#discussion_r1199602161
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -119,10 +119,10 @@ allprojects {
if (rootProject.runtimeJavaVersion < JavaVersion.VERSION_16) {
jvmArgs '--illegal-access=deny'
}
-
+
// Lucene needs to optional modules at runtime, which we want to enforce
for testing
// (if the runner JVM does not support them, it will fail tests):
- jvmArgs '--add-modules', 'jdk.unsupported,jdk.management'
+ jvmArgs '--add-modules',
'jdk.unsupported,jdk.management,jdk.incubator.vector'
Review Comment:
We should only enable jdk.incubator.vector if our tests are running with the
exact Java version. This would fail e.g. on Java 11 (branch 9.x when
backported) or with future versions when it went out of incubation.
Maybe we should have a global gradle variable to list which features are
anbled for which java version (like for panamaForeign).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
