rmuir commented on PR #12311: URL: https://github.com/apache/lucene/pull/12311#issuecomment-1559022634
> Apologies, I'm don't have much time early this week, but hope to be more active later in the week. I know that there are still outstanding questions around testing, luceneutil, etc, but I think that Robert's benchmark has been invaluable and laid solid foundations here, so I fully expect that we'll be able to work through the other outstanding issues. Overall the code is really coming together. Noice! Thank you for the help so far. I'm in the opposite boat and will be busy for the rest of week. I do want to find time to revisit the Binary* functions on ARM eventually (I just hate doing basically anything on the Mac). Otherwise, a lot of this code is just messy. Sorry, I didn't make really any attempt for it to have any quality whatsoever. Last time i wrote code to this vector API it just sat on the shelf for years, so writing clean code seemed like a premature optimization, or at least that's my excuse. we can fix it up :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
