JarvisCraft commented on PR #12343: URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572199694
> Use `TermAttribute` to do this. the backing `CharTermAttributeImpl` implements it also. Not sure if it will work in our scenario, but I will giv eit a try. This however still does not solve the problem of defensive copying. > If we add methods as you propose, it means anything using it will be broken for non-UTF8 terms. But does not it mean that the existing `BytesRef(CharSequence)` constructor is already broken? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
