eliaporciani commented on code in PR #12253: URL: https://github.com/apache/lucene/pull/12253#discussion_r1217704204
########## lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/KnnVectorValueSource.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.queries.function.valuesource; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.queries.function.FunctionValues; +import org.apache.lucene.queries.function.ValueSource; + +/** function that returns a constant vector value for every document. */ +public class KnnVectorValueSource extends ValueSource { + + List<Number> vector; + + public KnnVectorValueSource(List<Number> constVector) { + this.vector = constVector; + } + + @Override + public FunctionValues getValues(Map<Object, Object> context, LeafReaderContext readerContext) + throws IOException { + return new FunctionValues() { + @Override + public float[] floatVectorVal(int doc) { Review Comment: This method is called for each document and it introduces an overhead. We should try to create the arrays at most once. The problem is that we have both the byte[] and the float[] arrays as possibilities and we cannot know which one will be needed in advance. Maybe we can create the float[] vector (and byte[]) lazily during the first call of this method and store it in a variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
