uschindler commented on PR #12281: URL: https://github.com/apache/lucene/pull/12281#issuecomment-1585743145
My proposal would be: - Revert all changes to all providers. The change to double is out of discussion now. We have some rounding errors for large vectors, but this has nothing to do with finite checks. We are a search engine that calculates float scores. The implementations in Panama and the unvectorized default one are different anyways. For a vector search engine it is just important to return a score, if it is precisie does not matter so much, it is only used for sorting - Add a method `VectorUtil#checkFinite(float[] vector)` that throws `IllegalArgumentException` (and does the missing null check gratis) - Call this method from both ctors in `KNNVectorField`. The ctors are currently missing the checks that are mentioned in the javadocs. E.g., theres no null check, which is a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
